22 a) ii) (1 Viewer)

[MacAus91]

what did you put for the error in the algorithm?
i wrote about the then statement being on the next line, but i dont know if that would affect it... im thinking it must of been something to do with the logic of the code...

 

[Terlob]

I had 3 errors... can't remember them though

EDIT - Wrong question

 

[sdsdsdsdsd]

what did you put for the error in the algorithm?
i wrote about the then statement being on the next line, but i dont know if that would affect it... im thinking it must of been something to do with the logic of the code...

I said the error was 'found' turning to 'TRUE' which would end the loop, which I knew was wrong because no language does that.


It looked like this (off the top of my head..):

IF accountFile.accountNumber = accountNumber 
    THEN found = True
    accountName = accountFile.accountName
    accountAddress = accountFile.accountAddress
ELSE
   READ accountFile
ENDIF

I amended it like this:

IF accountFile.accountNumber = accountNumber THEN
    accountName = accountFile.accountName
    accountAddress = accountFile.accountAddress
    found = True
ELSE
   READ accountFile
ENDIF

I could not find a real error.

 

[ondroo]

ahh that question was lame. i just said the THEN should be on the line above as it is a syntax error or something :S

 

[Fly Kite]

there was a syntax error and something else if i remember correctly.
and i think it was something like
IF found NOT false
or something

 

[sdsdsdsdsd]

IF NOT [B]found[/B] THEN

Thought that might have been it.

 

[ondroo]

i dont get how it can be anything else... here is the whole algorithm;

BEGIN FindAccountData(accountNumber, accountName, accountAddress)
   OPEN accountFile
   READ accountFile
   found = false
   WHILE NOT found
         IF accountFile.accountNumber = accountNumber
                 THEN found = true
                         accountName = accountFile,accountName
                         accountAddress = accountFile.accountAddress
                 ELSE
                          READ accountFile
         ENDIF
   ENDWHILE
   CLOSE accountfile
END FindAccountData

I don't think theres anything wrong with the found variable as it is initialised to false and the statement "WHILE NOT found" is equivalent to "WHILE found = false". Therefore the assigning it to true short circuits the loop when the correct accountNumber is found. Nothing wrong with that

If u wanted to get picky u could say the indentation of the if statement (e.g. the THEN and else and stuff) but thats not realllllyy an error.

Besides it says "There is an error in the algorithm. Describe the error" as in error not errors as in ONE error.

 

[Terlob]

I had that it had an infinite loop if the correct accountNumber wasnt found. That is if

IF accountFile.accountNumber = accountNumber

Is never met, than the flag will never be set to true and it will keep looping through forever. I could be wrong as though

 

[betonit169]

no wayyy thats what i did noiccceee

 

[witide]

I commented on the syntax error of the IF..THEN..ELSE, and also added that there was a possibility of an infinite loop.

 

[sdsdsdsdsd]

I didn't put that but yeah I am sure that's what it's going to be, it should check if the end of file had been reached or if READ failed.

 

[ondroo]

ahh tru i totally didnt see that.... daaamn

 

[Terlob]

no wayyy thats what i did noiccceee

Great minds think alike

 

[betonit169]

Great minds think alike

damn straight

 

[whitey9999]

I wrote down the " WHILE NOT false " didnt think it was proper syntax coz you cant really do that. even if it is a boolean

 

[i4gotmypass]

I had that it had an infinite loop if the correct accountNumber wasnt found. That is if

IF accountFile.accountNumber = accountNumber

Is never met, than the flag will never be set to true and it will keep looping through forever. I could be wrong as though

i put this.

the algorithm is just designed to read accountFiles forever until it finds a match so if one isn't found, the algorithm is stuck in that loop.

 

[fishbulb]

I wrote that its a logic error and the program is stuck in an infinite loop because it is reading the same accountFile continuosly. It does not even stop when there are no more accountfiles to read.

But i didnt mention the "WHILE NOT found" should be "WHILE found = False".

In part iii) I did not fix the error as that was not what the question was asking.
I just added:
If found = true then
PRINT accountName
PRINT accountAddress
End If

 

[darcys22]

Found is a boolean value, if NOT Found means if Found = 0, The infinite loop is what i put.